Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UnsafeSlice and use unsafe.Slice #717

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Remove UnsafeSlice and use unsafe.Slice #717

merged 1 commit into from
Apr 7, 2024

Conversation

henrybear327
Copy link
Contributor

@henrybear327
Remove UnsafeSlice and use unsafe.Slice
9e3d732 
References:
- etcd-io#713
- etcd-io#566

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327 henrybear327 mentioned this pull request Apr 6, 2024
Merged
fuweid
fuweid reviewed Apr 7, 2024
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good. I would like to keep it as it's because the original code is still working.
It's not bugfix.

@ivanvc
Copy link
Member

ivanvc commented Apr 7, 2024

changes look good. I would like to keep it as it's because the original code is still working. It's not bugfix.

@fuweid, this backport comes from this comment: https://github.com/etcd-io/bbolt/pull/713/files#r1552336503

@ahrtr
Copy link
Member

ahrtr commented Apr 7, 2024

changes look good. I would like to keep it as it's because the original code is still working.
It's not bugfix.

I have no strong opinion on this. Either way works for me. Since we will maintain release-1.3 for a long time, so I prefer to update it per golang suggested way to get rid of the deprecated solution.

fuweid
fuweid approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr ahrtr merged commit 886753c into etcd-io:release-1.3 Apr 7, 2024
9 checks passed
@henrybear327 henrybear327 deleted the fix/remove_UnsafeSlice branch April 7, 2024 18:12
@ahrtr ahrtr mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@henrybear327 @ivanvc @ahrtr @fuweid